Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/refactor/rename: Unterminated single quote in usage string. #12981

Closed
dmitshur opened this issue Oct 19, 2015 · 4 comments
Closed

x/tools/refactor/rename: Unterminated single quote in usage string. #12981

dmitshur opened this issue Oct 19, 2015 · 4 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

rename.go#L103 currently has:

% gorename -from \"bytes\".Buffer.Len' -to Size

It has an unterminated single quote. It should be fixed either by adding a single quote in front (and not escaping the double quotes):

% gorename -from '"bytes".Buffer.Len' -to Size

Or by removing the existing single quote:

% gorename -from \"bytes\".Buffer.Len -to Size
@dominikh
Copy link
Member

You don't need to/must not escape the double quotes when they're enclosed in single quotes.

@dmitshur
Copy link
Contributor Author

Thanks @dominikh, I've edited the original post to fix that.

@rakyll rakyll added this to the Unreleased milestone Oct 19, 2015
@rakyll
Copy link
Contributor

rakyll commented Oct 19, 2015

/cc @alandonovan

@alandonovan
Copy link
Contributor

Fixed by https://go-review.googlesource.com/#/c/16053/

@golang golang locked and limited conversation to collaborators Oct 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@dominikh @rakyll @dmitshur @alandonovan @gopherbot