You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The lack of the OneLine syntax.Flag when parsing a syntax.Regexp should correspond to an m regexp flag, which defaults to false when compiling a regexp.Regexp if not present. The syntax.writeRegexp function should therefore add the m flag when it is needed. Instead, it looks like the writeRegexp function subtracts the m flag when it is not needed, which would be incorrect based on the default functionality.
Also includes a minor golint cleanup in the tests.
Change-Id: I8c0fc81479e635e7cca18d5c48c28b654afa59d8
Reviewed-on: https://go-review.googlesource.com/25380
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
The lack of the
OneLine
syntax.Flag when parsing asyntax.Regexp
should correspond to anm
regexp flag, which defaults to false when compiling aregexp.Regexp
if not present. Thesyntax.writeRegexp
function should therefore add them
flag when it is needed. Instead, it looks like thewriteRegexp
function subtracts them
flag when it is not needed, which would be incorrect based on the default functionality.Here is a Go Playground to demonstrate this.
The text was updated successfully, but these errors were encountered: