Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/trace: no way to know whether Finish has been called #12857

Open
iamqizhao opened this issue Oct 6, 2015 · 1 comment
Open

x/net/trace: no way to know whether Finish has been called #12857

iamqizhao opened this issue Oct 6, 2015 · 1 comment
Milestone
Unreleased

Comments

@iamqizhao
Copy link

@Sajmani
The current trace package does not provide a way for the caller of trace.FromContext to know whether trace.Trace.Finish has been called on this Trace (usually by another goroutine) so that the caller may operate on a finished Trace.
@Sajmani
Copy link
Contributor

Sajmani commented Oct 6, 2015

I think we should make calling trace's methods after Finish a no-op. This will require some refactoring since we recycle trace objects to reduce allocations.

@adg adg changed the title issue with golang.org/x/net/trace x/net/trace: no way to know whether Finish has been called Oct 6, 2015
@ianlancetaylor ianlancetaylor added this to the Unreleased milestone Oct 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@ianlancetaylor @Sajmani @iamqizhao