Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/mobile/gl: make GL driver crashes easier to reproduce #12786

Closed
crawshaw opened this issue Sep 29, 2015 · 1 comment
Closed

x/mobile/gl: make GL driver crashes easier to reproduce #12786

crawshaw opened this issue Sep 29, 2015 · 1 comment
Labels
FrozenDueToAge

Comments

@crawshaw
Copy link
Member

We now have a command buffer and a thread switch between when a GL method is called in Go and when it is executed in the driver, making it hard to debug a segfault or similar from the GL driver (see #12718 for an example).

This could be improved in -tags gldebug mode by shrinking the workbuffer from 3 to 1, and turning all GL calls into blocking calls. Then a Go panic would at least include the name of the GL function that caused the segfault.
@crawshaw crawshaw self-assigned this Sep 29, 2015
@crawshaw crawshaw mentioned this issue Sep 29, 2015
Closed
@gopherbot
Copy link

CL https://golang.org/cl/15160 mentions this issue.

@golang golang locked and limited conversation to collaborators Oct 4, 2016
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 10, 2021
@crawshaw
gl: mark all functions as blocking in debug mode
886ea71 
This means that if the OpenGL driver crashes, the stack trace will
contain a goroutine blocked in the function that caused the panic.

Fixes golang/go#12786

Change-Id: I039c74f9e24de777b925475a50e8c96129692f70
Reviewed-on: https://go-review.googlesource.com/15160
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 11, 2021
@crawshaw
gl: mark all functions as blocking in debug mode
e22e809 
This means that if the OpenGL driver crashes, the stack trace will
contain a goroutine blocked in the function that caused the panic.

Fixes golang/go#12786

Change-Id: I039c74f9e24de777b925475a50e8c96129692f70
Reviewed-on: https://go-review.googlesource.com/15160
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crawshaw @gopherbot