-
Notifications
You must be signed in to change notification settings - Fork 18k
x/tools/godoc/vfs/zipfs: ReadDir("/") returns error "file not found: /" #12743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Does your zip file contain leading / in filenames? Please ask questions on the mailing list. Thanks. |
Which mailing list? Sorry if this was the wrong spot. The contribution guidelines suggest filing an issue here as the first place to start. Appreciate the guidance; eager to help out. |
We only built zipfs for godoc, and it's likely that godoc just never needs to read from If you fix this, be sure to verify and state in your commit message that godoc in zip mode still works. |
Here's my current patch. Should I submit it for code review? |
Sure. We don't review code outside of Gerrit for both practical matters (crappy code review tools elsewhere, in general) and legal paranoia reasons (Gerrit enforces CLA compliance for us). |
CL https://golang.org/cl/16925 mentions this issue. |
go version go1.5 darwin/amd64
I created a
vfs.FileSystem
usingzipfs
andReadDir("/")
returnsnil, "file not found: /"
.I expected it to return a slice of
os.FileInfo
for the files at the root of the zip file and anil
error.I've written tests and a fix but need guidance on next steps. Please advise!
Full Repro Script
Currently results in:
With fix, results in:
The text was updated successfully, but these errors were encountered: