Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: rebuild of std is too sensitive to GOROOT #12690

Closed
minux opened this issue Sep 19, 2015 · 1 comment
Closed

cmd/go: rebuild of std is too sensitive to GOROOT #12690

minux opened this issue Sep 19, 2015 · 1 comment
Milestone

Comments

@minux
Copy link
Member

minux commented Sep 19, 2015

One symptom:
The behavior of GOROOT_BOOTSTRAP=$HOME/go1.5-bootstrap ./make.bash and
GOROOT_BOOTSTRAP=$HOME/go1.5-bootstrap/ ./make.bash are vastly different
even though the only difference is just a trailing slash added to GOROOT.
($HOME/go1.5-bootstrap is a Go 1.5 installation)

The first will not rebuild std in $GOROOT_BOOTSTRAP, however, the later will.

An easier repro:

$ goroot=`go env GOROOT`
$ cd $goroot/src; ./make.bash # a fresh build
$ GOROOT=$goroot go build -v ../test/helloworld.go # it only build helloworld.go
$ GOROOT=$goroot/ go build -v ../test/helloworld.go # it will recompile runtime

This behavior suggests that some paths that get included in the buildid hash
are not properly Cleaned.

@minux minux added this to the Go1.6 milestone Sep 19, 2015
@gopherbot
Copy link

CL https://golang.org/cl/16483 mentions this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants