Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: wrong createCmd for submodules #12612

Closed
toxeus opened this issue Sep 14, 2015 · 4 comments
Closed

cmd/go: wrong createCmd for submodules #12612

toxeus opened this issue Sep 14, 2015 · 4 comments
Milestone

Comments

@toxeus
Copy link

toxeus commented Sep 14, 2015

The createCmd for the submodules fails. I have clarified upstream if this is expected to fail. The result is that it is expected to fail as it is currently in the code. The correct createCmd therefore would be:

createCmd: []string{"clone {repo} {dir}", "-C={dir} submodule update --init --recursive"}
@ianlancetaylor
Copy link
Contributor

Can you give us a test case that fails with the current code and works with your suggested patch?

@toxeus
Copy link
Author

toxeus commented Sep 14, 2015

On git level the testcase is provided in the git mailing list thread I have linked in my first post. Sorry, I should have stated that clearer.

On go level you can reproduce the failure as follows:

export GO15VENDOREXPERIMENT=1
go get -d github.com/toxeus/test_for_issue

or any other git repo that has submodules.

The error message looks then like this:

# cd .; git --git-dir=/home/filip/go/src/github.com/toxeus/test_for_issue/.git submodule update --init --recursive
No submodule mapping found in .gitmodules for path 'vendor/golang.org/x/crypto'
package github.com/toxeus/test_for_issue: exit status 1

@ianlancetaylor ianlancetaylor added this to the Go1.6 milestone Sep 14, 2015
@StephanDollberg
Copy link

I think this is a dupe of #12573

@gopherbot
Copy link

CL https://golang.org/cl/17974 mentions this issue.

@rsc rsc closed this as completed in 761ac75 Dec 17, 2015
@golang golang locked and limited conversation to collaborators Dec 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants