Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mime: Comment for (*WordDecoder).Decode is wrong #12568

Closed
nussjustin opened this issue Sep 10, 2015 · 4 comments
Closed

mime: Comment for (*WordDecoder).Decode is wrong #12568

nussjustin opened this issue Sep 10, 2015 · 4 comments
Labels
Documentation FrozenDueToAge
Milestone
Go1.6

Comments

@nussjustin
Copy link
Contributor

The comment for Decode states that "If word is not a valid RFC 2047 encoded-word, word is returned unchanged.", but the implementation always returns an empty string for not RFC 2047 encoded words.

The comment should be updated to represent the actual implementation.
@ianlancetaylor ianlancetaylor added this to the Go1.6 milestone Sep 10, 2015
@bradfitz
Copy link
Contributor

Or even Go 1.5.2, since it's just a doc change, @ianlancetaylor?

@ianlancetaylor
Copy link
Contributor

Sure, 1.5.2 is fine with me. I don't know anything about this code but the issue does suggest that the comment is completely wrong.

@ianlancetaylor ianlancetaylor modified the milestones: Go1.5.2, Go1.6 Sep 10, 2015
@rsc
Copy link
Contributor

rsc commented Nov 13, 2015

Not important enough for Go 1.5.2. There's too much already.

@rsc rsc modified the milestones: Go1.6, Go1.5.2 Nov 13, 2015
@bradfitz
Copy link
Contributor

This is a doc fix.

@golang golang locked and limited conversation to collaborators Nov 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge
Projects
None yet
Milestone
Go1.6
Development

No branches or pull requests
5 participants
@bradfitz @rsc @ianlancetaylor @nussjustin @gopherbot