Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestGoTestCpuprofileLeavesBinaryBehind and TestGoTestDashOWritesBinary fail #12554

Closed
frederich opened this issue Sep 9, 2015 · 5 comments
Closed

cmd/go: TestGoTestCpuprofileLeavesBinaryBehind and TestGoTestDashOWritesBinary fail #12554

frederich opened this issue Sep 9, 2015 · 5 comments
Labels
FrozenDueToAge OS-Windows
Milestone
Go1.6

Comments

@frederich
Copy link
Contributor

The both test below fail on go1.5.1 Windows amd64.

--- FAIL: TestGoTestCpuprofileLeavesBinaryBehind (0.83s)
go_test.go:251: running testgo [test -cpuprofile errors.prof errors]
go_test.go:266: standard output:
go_test.go:267: ok errors 0.131s

    go_test.go:158: remove E:\tmp\gotest793636497: Das Verzeichnis ist nicht leer.

--- FAIL: TestGoTestDashOWritesBinary (1.21s)
go_test.go:251: running testgo [test -o E:\tmp\gotest402419724\myerrors.test.exe errors]
go_test.go:266: standard output:
go_test.go:267: ok errors 0.137s

    go_test.go:158: remove E:\tmp\gotest402419724: Das Verzeichnis ist nicht leer.

FAIL
@bradfitz
Copy link
Contributor

bradfitz commented Sep 9, 2015

Does go test -short cmd/go pass on the same machine?

@bradfitz bradfitz changed the title test: TestGoTestCpuprofileLeavesBinaryBehind and TestGoTestDashOWritesBinary fail cmd/go: TestGoTestCpuprofileLeavesBinaryBehind and TestGoTestDashOWritesBinary fail Sep 9, 2015
@ianlancetaylor
Copy link
Contributor

This is probably another instance of issue #9606 .

@ianlancetaylor ianlancetaylor added this to the Go1.6 milestone Sep 9, 2015
@frederich
Copy link
Contributor Author

Go test pass on the same machine.

go test -short cmd/go
ok cmd/go 54.011s

But sometimes all.bat fails sometimes not. I've the same suspicion like Ian.

@alexbrainman
Copy link
Member

But sometimes all.bat fails sometimes not.

If it comes and goes, it cannot be issue #9606 - if you had read-only files in your temp directory, they would be there all the time.

Unfortunately I cannot reproduce the issue here. But I will look for it.

Alex

@rsc
Copy link
Contributor

rsc commented Nov 5, 2015

Assuming this is #9606.

@rsc rsc closed this as completed Nov 5, 2015
@golang golang locked and limited conversation to collaborators Nov 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-Windows
Projects
None yet
Milestone
Go1.6
Development

No branches or pull requests
6 participants
@bradfitz @rsc @frederich @ianlancetaylor @gopherbot @alexbrainman