Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/dist: GOARM inference fails with arm64 kernel #12548

Closed
mwhudson opened this issue Sep 9, 2015 · 7 comments
Closed

cmd/dist: GOARM inference fails with arm64 kernel #12548

mwhudson opened this issue Sep 9, 2015 · 7 comments
Labels
FrozenDueToAge

Comments

@mwhudson
Copy link
Contributor

mwhudson commented Sep 9, 2015

This is a selfish bug report: the fastest and most reliable 32-bit arm environment I have access to is a armhf chroot on an arm64 system and currently I'm fairly sure it falls back to GOARM=5 when running ./all.bash. I think checking assuming GOARM=7 when uname -m == armv8l would be appropriate.
@bradfitz
Copy link
Contributor

bradfitz commented Sep 9, 2015

Sounds fine.

@minux
Copy link
Member

minux commented Sep 9, 2015 via email

@bradfitz
Copy link
Contributor

bradfitz commented Sep 9, 2015

The build is slow enough. I don't want to see it compiling and running a program for a simple check.

Can you modify CL 3973 to make it compile those two probe functions into the dist binary itself, and then just make dist exec its own binary (argv[0]) as a child to do the probe and see whether it crashes? It would at least eliminate the extra compile and disk I/O.

@gopherbot
Copy link

CL https://golang.org/cl/14413 mentions this issue.

@minux
Copy link
Member

minux commented Sep 9, 2015 via email

@gopherbot
Copy link

CL https://golang.org/cl/3973 mentions this issue.

minux added a commit that referenced this issue Sep 10, 2015
@minux
cmd/dist: re-enable GOARM auto-detection
3f2baa3 
cmd/dist will re-exec itself to detect VFP support at run-time.

Fixes #9732, #12548.

Change-Id: I9ad0c5c7fa3e97bd79a32da372e1a962565bb3af
Reviewed-on: https://go-review.googlesource.com/3973
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@mwhudson
Copy link
Contributor Author

mwhudson commented Oct 4, 2015

Minux's CL fixed this.

@mwhudson mwhudson closed this as completed Oct 4, 2015
mwhudson added a commit to mwhudson/go that referenced this issue Jan 4, 2016
@mwhudson
cmd/dist: default to GOARM=7 on ARMv8
71636c2 
Fixes golang#12548

Change-Id: I6727a49d7da1167a5f72608399c98b33b9a5d1df
@golang golang locked and limited conversation to collaborators Oct 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bradfitz @minux @mwhudson @gopherbot