You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When renaming a symbol in an internal package, gorename finds and reports buggy packages outside the internal tree:
$ gorename -dryrun -from '"cmd/compile/internal/gc".Node' -to Qux
While scanning Go workspace:
Package "code.google.com/p/draw2d/draw2d/curve": found packages draw2d (arc.go) and curve (cubic_float64.go) in /gopath/src/code.google.com/p/draw2d/draw2d/curve.
Package "github.com/banthar/gl/examples/glfw": found packages glfw (glfw.go) and main (main.go) in /gopath/src/github.com/banthar/gl/examples/glfw.
Scanning the entire workspace seems unnecessary in this case, since symbols in internal packages cannot be imported outside the internal tree.
go version:
go version devel +e92d0d8 Tue Sep 1 16:28:49 2015 +0000 linux/amd64
The text was updated successfully, but these errors were encountered:
Because of Go's embedding mechanism, renaming symbols within internal packages can have effects that are visible to packages outside the "internal" subtree. So, this counterintuitive scan is required.
The oracle does need to be made more robust when scanning the entire workspace, though.
When renaming a symbol in an internal package, gorename finds and reports buggy packages outside the internal tree:
Scanning the entire workspace seems unnecessary in this case, since symbols in internal packages cannot be imported outside the internal tree.
go version:
The text was updated successfully, but these errors were encountered: