Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/json: Inconsistent spelling of unmarshaling/unmarshalling. #12431

Closed
dmitshur opened this issue Sep 1, 2015 · 3 comments
Closed

encoding/json: Inconsistent spelling of unmarshaling/unmarshalling. #12431

dmitshur opened this issue Sep 1, 2015 · 3 comments

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Sep 1, 2015

On lastest master commit, in encoding/json/decode.go file, there are two variations of spelling of the same word:

var spellingOccurrences = map[string]int{
    "unmarshaling":  2,
    "unmarshalling": 1,
}

It can be made better by having a consistent spelling, making it easier to find out which is the canonical spelling.

Edit: Including test files and "marshaling"/"marshalling", the count goes to 8 and 3, respectively.

@gopherbot
Copy link

CL https://golang.org/cl/14150 mentions this issue.

@adg adg closed this as completed in 143f3fd Sep 23, 2015
@golang golang locked and limited conversation to collaborators Sep 23, 2016
@gopherbot
Copy link

CL https://golang.org/cl/33017 mentions this issue.

@bradfitz
Copy link
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants