Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/benchmarks/driver: update for Go 1.5 runtime/trace #12343

Closed
nickng opened this issue Aug 26, 2015 · 2 comments
Closed

x/benchmarks/driver: update for Go 1.5 runtime/trace #12343

nickng opened this issue Aug 26, 2015 · 2 comments

Comments

@nickng
Copy link

nickng commented Aug 26, 2015

Environment

Output from go version

    go version go1.5 linux/amd64

Problem

The problem is related to compilation of golang/benchmarks (i.e. golang.org/x/benchmarks).

I tried to run go build golang.org/x/benchmarks/bench (then go install) as suggested by README, to build the benchmark executable which runs the benchmark.

Here suggests the existence of StartTrace and StopTrace in runtime/pprof but they do not exist.

What I expect to see

bench executable created in $GOPATH/bin/ (no output)

What I see instead

# golang.org/x/benchmarks/driver
driver/driver.go:91: undefined: pprof.StartTrace
driver/driver.go:95: undefined: pprof.StopTrace
@minux
Copy link
Member

minux commented Aug 26, 2015 via email

@minux minux changed the title runtime/pprof: Missing StartTrace and StopTrace x/benchmarks/driver: update for Go 1.5 runtime/trace Aug 26, 2015
@rsc rsc added this to the Unreleased milestone Oct 23, 2015
@ALTree
Copy link
Member

ALTree commented May 13, 2019

This was fixed in golang/benchmarks@7e3f3ec. Closing here.

@ALTree ALTree closed this as completed May 13, 2019
@golang golang locked and limited conversation to collaborators May 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants