Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/gotype: broken for go <1.5 #12305

Closed
bwester opened this issue Aug 25, 2015 · 4 comments
Closed

x/tools/cmd/gotype: broken for go <1.5 #12305

bwester opened this issue Aug 25, 2015 · 4 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@bwester
Copy link

bwester commented Aug 25, 2015

Commit 12c48ced (cmd/gotype: use std lib go/types instead of x/tools version) to the "gotype" tool prevents the tool from being built on versions of go prior to 1.5. For instance:

$ curl https://storage.googleapis.com/golang/go1.4.2.linux-amd64.tar.gz | tar xz
$ export GOROOT=$HOME/go
$ export PATH=$PATH:$GOROOT/bin
$ export GOPATH=$HOME/gopath
$ go version
go version go1.4.2 linux/amd64
$ go get golang.org/x/tools/cmd/gotype
package golang.org/x/tools/cmd/gotype
    imports go/importer: unrecognized import path "go/importer"
package golang.org/x/tools/cmd/gotype
    imports go/types: unrecognized import path "go/types"

Just going by the commit, it would appear that the future of "gotype" is to use packages that have recently been included in Go's standard library. Is this an intentional deprecation of the command for older versions?

cc: @griesemer
@bwester bwester changed the title gotype is broken for go 1.4.2 users gotype tool is broken for go <1.5 Aug 25, 2015
@mikioh mikioh added this to the Unreleased milestone Aug 25, 2015
@mikioh mikioh changed the title gotype tool is broken for go <1.5 x/tools/cmd/gotype: broken for go <1.5 Aug 25, 2015
@griesemer
Copy link
Contributor

https://go-review.googlesource.com/13899

pending review

@bwester
Copy link
Author

bwester commented Aug 25, 2015

Thanks for fixing this problem so quickly!

@griesemer
Copy link
Contributor

Apologies for breaking it in the first place.

@griesemer
Copy link
Contributor

This was fixed by https://go-review.googlesource.com/13899.

raphael pushed a commit to goadesign/goa that referenced this issue Mar 18, 2016
Remove Go 1.4 from TravisCI
61f2100 
The compiler used by Travis has a bug that prevents the execution of the tests.
golang/go#12305
@golang golang locked and limited conversation to collaborators Dec 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@mikioh @bwester @griesemer @gopherbot