Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: LookupPort("tcp", "123") no longer returns 123 #12263

Closed
rsc opened this issue Aug 21, 2015 · 2 comments
Closed

net: LookupPort("tcp", "123") no longer returns 123 #12263

rsc opened this issue Aug 21, 2015 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.5.1

Comments

@rsc
Copy link
Contributor

rsc commented Aug 21, 2015

This broke because the cgo-based lookup did accept "123" but the Go-based lookup does not. This means the behavior was at best inconsistent before, but it does make sense that you should be able to look up tcp/80 in addition to tcp/http.

If we have a more serious problem for a 1.5.1 this would be a candidate for an add-on.
@rsc rsc self-assigned this Aug 21, 2015
@rsc rsc added this to the Go1.5.1 milestone Aug 21, 2015
@gopherbot
Copy link

CL https://golang.org/cl/13915 mentions this issue.

@rsc rsc closed this as completed in 35365b9 Aug 27, 2015
@gopherbot
Copy link

CL https://golang.org/cl/14243 mentions this issue.

rsc added a commit that referenced this issue Sep 8, 2015
@rsc @broady
[release-branch.go1.5] net: restore LookupPort for integer strings
a7e30ce 
This worked in Go 1.4 but was lost in the "pure Go" lookup
routines substituted late in the Go 1.5 cycle.

Fixes #12263.

Change-Id: I77ec9d97cd8e67ace99d6ac965e5bc16c151ba83
Reviewed-on: https://go-review.googlesource.com/13915
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-on: https://go-review.googlesource.com/14243
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@golang golang locked and limited conversation to collaborators Sep 4, 2016
@rsc rsc removed their assignment Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5.1
Development

No branches or pull requests
2 participants
@rsc @gopherbot