If someone can make this work, please do.

Add upgrade attributes in wxs source

<Product ...>
...
<Upgrade ...>
  <UpgradeVersion ... />
</Upgrade>
</Product>

@linquize want to implement it? I have no idea what I'm doing with the wxs stuff.

May be try to study from other projects
I remember the following project can upgrade from old version

https://github.com/jgm/pandoc/blob/master/windows/pandoc.wxs

I can try to tackle this. (I've been looking for something to work on and this doesn't seem too hard)

@tylrmac please do! let me know if you need help.

@adg any tips for getting a Windows machine/VM set up for building a release build? I've never done a release build for Windows before. Already have my changes I'd like to test.

@tylrmac

See this from #11740 (comment)

you could just run releaselet.go from a directory that contains a go directory containing a compiled Go tree. (and stub out the stuff in releaselet.go that tries to do the godoc/tour stuff)

You will need a windows computer with all bits installed.

golang.org/x/build/env/windows/README describes the way Go builders are configured. You would only need appropriate bits of software installed - you can use "winstrap" program as described in README.

Alex

@alexbrainman Thanks! Have everything set up correctly now. Now to actually fix the problem...

I have it working but the solution by default removes the old version before installing a newer version. Is that desired behavior?

It's possible to prompt the user that the installer will remove the old install but I want to double check before I get it ready for code review.

@tylrmac I don't know what is the right choice here. I will let @adg decide.

Alex

@tylrmac It would be great to prompt the user before deleting anything.

I have this mostly working. Having a baby in a few days so will have to put off testing until after then.

Thanks for your efforts!

On 28 August 2015 at 07:03, Tyler McEntee notifications@github.com wrote:

I have this mostly working. Having a baby in a few days so will have to
put off testing until after then.

—
Reply to this email directly or view it on GitHub
#12213 (comment).

ping

Sorry @linquize, I have a fix but won't be able to do much with it until next week. Currently in the hospital awaiting the birth of our first child.

@tylrmac, if you sent me what you have so far, I can pick up from there. I have some experience with wxs from current projects... BTW, all the best for you and your familiy, hope all went well!

https://go-review.googlesource.com/#/c/18071/

CL https://golang.org/cl/18071 mentions this issue.

Will it be included in 1.5.3?

Will it be included in 1.5.3?

I don't see why it wouldn't, but I don't know for sure. @adg builds msi files.

Alex

I added the 1.5.3 milestone so that can be considered for 1.5.3 (if there is a 1.5.3). I don't know whether this is appropriate or not.

In golang website,
"If you are upgrading from an older version of Go you must first remove the existing version. "
This statement is no longer valid since 1.5.3 (Windows)

This statement is no longer valid since 1.5.3 (Windows)

I think you're correct. I think we should change website text. Except I don't know where the source code is.

Alex

@tylrmac updated Windows installer package (msi) in 1.5.3. The website text shiuld reflect this change.

Great work @tylrmac !

@adg it would be great to tell people about this! :) (the website still says "If you are upgrading from an older version of Go you must first remove the existing version.")

I would rather keep the text as-is, as it applies generally to all kinds of Go installation.

Further, encouraging people to uninstall before installing a new version will lead to fewer support queries in the long term.