New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: test failures: TestGoInstallRebuildsStalePackagesInOtherGOPATH and TestBuildDashIInstallsDependencies #12205
Comments
Do the systems differ in filesystem timestamp resolution? E.g. is the first one ext3, or ext4-that-was-once-ext3? |
The first (failures) is nfs with /tmp on ext3 The second (all ok) is all ext3 |
This looks like an error in test logic, so not something for a point release. It looks to me like func measureTick has the test backward:
I think that "for " should be "for !", negating the first half of the conjunction. If I'm reading it correctly, the current test will decide on microsecond precision for file systems with only second precision and vice versa. |
I think the measureTick logic is correct. If rounding to t gives you the same time, you don't know anything--the time might have been a multiple of t anyhow. So you keep going. If rounding to t gives you a different time, then you can expect that a sleep of t will give you a different time. |
@ianlancetaylor, yes, I was clearly misreading. I wonder if maybe the os.Stat gets cached Linux data with microsecond resolution even though NFS only stores 1-second resolution, or something like that. |
CL https://golang.org/cl/17953 mentions this issue. |
Installing Go from fresh source, release branch go1.5, I get:
$ for i in -s -r -v -m -p -i -o; do uname $i; done
Linux
2.6.32-5-amd64
#1 SMP Wed Jun 17 16:09:06 UTC 2015
x86_64
unknown
unknown
GNU/Linux
On another, virtually identical machine, it installs without problems:
$ for i in -s -r -v -m -p -i -o; do uname $i; done
Linux
2.6.32-5-amd64
#1 SMP Sat Jul 12 16:47:57 UTC 2014
x86_64
unknown
unknown
GNU/Linux
The text was updated successfully, but these errors were encountered: