Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/trace: registration is hard to use with third-party HTTP muxers #12195

Closed
mwitkow opened this issue Aug 19, 2015 · 2 comments
Closed

x/net/trace: registration is hard to use with third-party HTTP muxers #12195

mwitkow opened this issue Aug 19, 2015 · 2 comments
Labels
FrozenDueToAge

Comments

@mwitkow
Copy link

mwitkow commented Aug 19, 2015

As discussed in
https://groups.google.com/forum/#!topic/golang-nuts/Hihyzgci1EU

I'd like to use the amazing golang.org/x/net/trace library. Howevever, my HTTP-serving binaries are using the Gorilla Mux for the request routing.
Unfortunately, the trace package doesn't expose the http.HandleFunc as a public interface, instead registering private methods in the package's init() function to the http.DeafultServerMux.

@dsymonds mentioned he already had this in his plans and asked for a ticket.
@dsymonds dsymonds self-assigned this Aug 19, 2015
@gopherbot
Copy link

CL https://golang.org/cl/13825 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/13824 mentions this issue.

dsymonds added a commit to golang/net that referenced this issue Aug 24, 2015
@dsymonds
trace: Make links in generated HTML be relative to the current path.
788d8d9 
This will make it easier to serve /debug/requests off a different path.

This is groundwork towards addressing golang/go#12195.

Change-Id: If29a4c329609df1d5b09a3a88b8bdf1f8b622e49
Reviewed-on: https://go-review.googlesource.com/13824
Reviewed-by: Dave Day <djd@golang.org>
@mikioh mikioh changed the title x/net/trace registration is hard to use with third-party HTTP muxers x/net/trace: registration is hard to use with third-party HTTP muxers Aug 24, 2015
@golang golang locked and limited conversation to collaborators Aug 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dsymonds @gopherbot @mwitkow