You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As part of fixing #12189 I wrote TestLookupDots that checks for rooted DNS names being returned from the lookup routines. On the builders, all the Unix systems agree (due to the fix in CL 13697) but Windows and Plan 9 do not:
--- FAIL: TestLookupDots (0.03s)
lookup_test.go:420: LookupAddr(8.8.8.8) = [google-public-dns-a.google.com], want names ending in .google.com. with trailing dot (mode=go)
lookup_test.go:437: LookupMX(google.com) = [aspmx.l.google.com:10 alt1.aspmx.l.google.com:20 alt2.aspmx.l.google.com:30 alt3.aspmx.l.google.com:40 alt4.aspmx.l.google.com:50], want names ending in .google.com. with trailing dot (mode=go)
lookup_test.go:449: LookupNS(google.com) = [ns2.google.com ns4.google.com ns1.google.com ns3.google.com], want names ending in .google.com. with trailing dot (mode=go)
lookup_test.go:460: LookupSRV(xmpp-server, tcp, google.com) returned cname=_xmpp-server._tcp.google.com, want name ending in .google.com. with trailing dot (mode=go)
lookup_test.go:464: LookupSRV(xmpp-server, tcp, google.com) returned addrs=[alt1.xmpp-server.l.google.com:5269:0:20 alt3.xmpp-server.l.google.com:5269:0:20 alt4.xmpp-server.l.google.com:5269:0:20 alt2.xmpp-server.l.google.com:5269:0:20 xmpp-server.l.google.com:5269:0:5], want names ending in .google.com. with trailing dot (mode=go)
FAIL
I believe they should match the others but since they have done this for all earlier Go releases too - that is, this behavior on Plan 9 and Windows is the same as it was on Go 1.4 - I am not going to change it for Go 1.5. We can fix this discrepancy deliberately in the regular Go 1.6 cycle.
The text was updated successfully, but these errors were encountered:
This CL also changes windows LookupSRV to return
_xmpp-server._tcp.google.com. as cname instead of google.com
similar to linux. Otherwise TestLookupDots still fails.
Updates #12193 (with plan9 still to do)
Change-Id: Id225e15bee95037cdb4226803506cce690c5d341
Reviewed-on: https://go-review.googlesource.com/13887
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This change returns rooted DNS names on Plan 9,
for consistency with other operating systems.
Updates #12193.
Change-Id: If983920c5b9a8f67d4ccb51bb295fac8dfb87e88
Reviewed-on: https://go-review.googlesource.com/15581
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: David du Colombier <0intro@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com>
As part of fixing #12189 I wrote TestLookupDots that checks for rooted DNS names being returned from the lookup routines. On the builders, all the Unix systems agree (due to the fix in CL 13697) but Windows and Plan 9 do not:
https://storage.googleapis.com/go-build-log/22995b82/windows-amd64-gce_1f5c31d1.log
https://storage.googleapis.com/go-build-log/22995b82/plan9-386_6f2fc89c.log
I believe they should match the others but since they have done this for all earlier Go releases too - that is, this behavior on Plan 9 and Windows is the same as it was on Go 1.4 - I am not going to change it for Go 1.5. We can fix this discrepancy deliberately in the regular Go 1.6 cycle.
The text was updated successfully, but these errors were encountered: