Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: add //go:noinline annotation support #12140

Closed
josharian opened this issue Aug 13, 2015 · 4 comments
Closed

cmd/compile: add //go:noinline annotation support #12140

josharian opened this issue Aug 13, 2015 · 4 comments
Labels
FrozenDueToAge

Comments

@josharian
Copy link
Contributor

Some compiler tests require disabling inlining for a function. That is frequently accomplishing by adding defer func() {}() or switch {} with a comment. This is fragile and awkward. Let's add //go:noinline support and update the existing tests.

cc @randall77
@josharian josharian changed the title cmd/compile: add //go:noline annotation support cmd/compile: add //go:noinline annotation support Aug 13, 2015
@randall77
Copy link
Contributor

I'm game. Does it mean "don't inline anything into this function" or "don't inline this function into anything else"? I'm guessing the latter.

@josharian
Copy link
Contributor Author

The latter. I'll send a CL at some point.

@josharian josharian self-assigned this Aug 13, 2015
@gopherbot
Copy link

CL https://golang.org/cl/13911 mentions this issue.

@josharian
Copy link
Contributor Author

This is now #12312.

@golang golang locked and limited conversation to collaborators Sep 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@josharian @randall77 @gopherbot