Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/rpc: lose cached Request on EOF #12103

Open
powerman opened this issue Aug 10, 2015 · 1 comment
Open

net/rpc: lose cached Request on EOF #12103

powerman opened this issue Aug 10, 2015 · 1 comment
Milestone
Unplanned

Comments

@powerman
Copy link

It looks like a (performance) bug at https://github.com/golang/go/blob/master/src/net/rpc/server.go#L578 - I think before req = nil this should be added:

server.freeRequest(req)
@ianlancetaylor ianlancetaylor added this to the Go1.6 milestone Aug 11, 2015
@rsc rsc modified the milestones: Unplanned, Go1.6 Dec 3, 2015
@meirf
Copy link
Contributor

meirf commented May 8, 2018 •
edited

The url posted by the OP is relative to master which changes over time and currently points to the wrong line. Here is the url relative to the latest commit when this issue was created:

go/src/net/rpc/server.go

Line 578 in 514eb4a

req = nil

(Sorry I don't have more value to add here right now in the form of actual code; will need to spend more time absorbing this package.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
4 participants
@rsc @powerman @meirf @ianlancetaylor