Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/vcs: FromDir doesn't work with srcRoot = "/" #12079

Closed
hectorj opened this issue Aug 8, 2015 · 3 comments
Closed

x/tools/go/vcs: FromDir doesn't work with srcRoot = "/" #12079

hectorj opened this issue Aug 8, 2015 · 3 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@hectorj
Copy link

hectorj commented Aug 8, 2015 

_, _, err := vcs.FromDir("/whatever/", "/")

gives the error directory "/whatever" is outside source root "/", which is incorrect
@ianlancetaylor ianlancetaylor added this to the Unreleased milestone Aug 8, 2015
@ianlancetaylor
Copy link
Contributor

CC @paranoiacblack

@hectorj
Copy link
Author

hectorj commented Aug 8, 2015

https://go-review.googlesource.com/#/c/13422/

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 12, 2019
@bcmills bcmills mentioned this issue Dec 2, 2022
Closed
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 26, 2023
@dmitshur
Copy link
Contributor

Thanks for the report. This package has been deprecated in #57051 and won't receive further development, so closing this as not planned.

@dmitshur dmitshur closed this as not planned Won't fix, can't repro, duplicate, stale Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @hectorj @ianlancetaylor @gopherbot