New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/dist: test should not rebuild by default #12064
Comments
Perhaps. This isn't really a user-visible tool. It's just used by the test infrastructure in the build coordinator. This is easy enough to fix but a) it would preclude listing or omitting any tests that are only known about after a build (none currently, but I'd like to omit stdlib packages from the list if they didn't have test files or test files with the right +build tags), and b) once we do this, then people will file bugs about I'd kinda prefer to do nothing. |
Counter proposal, -list enables -no-rebuild, which is what you need to pass I agree that it's an internal tool, but today I needed to use -list to On Fri, Aug 7, 2015 at 5:01 PM, Brad Fitzpatrick notifications@github.com
|
That doesn't address either of my a) or b) comments. How about just failing immediately if you use |
Everything was built, passing -list wanted to build them again before it On Fri, 7 Aug 2015 17:43 Brad Fitzpatrick notifications@github.com wrote:
|
I am talking about the case where things are NOT built. You're discussing one specific set of cases. I'm considering all the states that the world might be in when you run said command, making sure the command does consistent things. My counter-counter proposal was:
You want a). I am proposing that a) is only acceptable if we also do b). |
The problem here is "rebuild by default". We should make test not rebuild by default, rename the flag to -rebuild, and pass -rebuild from run.{bash,bat,rc} where we need it. |
While searching for some issue, this issue can apparently be closed as no build occurs w/o specific flags.
Using a build.
|
@iwdgo, thanks. |
go tool dist test -list
rebuilds the standard library-list won't run any tests, so it shouldn't kick of an expensive rebuild.
The text was updated successfully, but these errors were encountered: