Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/refactor/rename: fails if cgo build would fail #12044

Open
jmhodges opened this issue Aug 6, 2015 · 0 comments
Open

x/tools/refactor/rename: fails if cgo build would fail #12044

jmhodges opened this issue Aug 6, 2015 · 0 comments
Labels
Refactoring Issues related to refactoring tools Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@jmhodges
Copy link
Contributor

jmhodges commented Aug 6, 2015

I have some CGO_CFLAGS and CGO_LDFLAGS settings I have to use to build a project I have, but gorename inside emacs doesn't have access to those.

gorename fails on this project (and ones that depend on it) because it cannot find the C headers. However, gorename doesn't support cgo and so doesn't really need to inspect those headers.

It would be nice for rename to not care about cgo so that we didn't have to mess with cgo's env variables for each project (esp since some might, in rare cases, have conflicting needs).

@ianlancetaylor ianlancetaylor added this to the Unreleased milestone Aug 6, 2015
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 12, 2019
@adonovan adonovan added the Refactoring Issues related to refactoring tools label Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactoring Issues related to refactoring tools Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

5 participants