Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: nilcheckelim allocates a lot #12021

Closed
josharian opened this issue Aug 4, 2015 · 3 comments
Closed

cmd/compile: nilcheckelim allocates a lot #12021

josharian opened this issue Aug 4, 2015 · 3 comments
Labels
FrozenDueToAge
Milestone
Go1.8

Comments

@josharian
Copy link
Contributor

CL 12332 brought impressive speed-ups to the SSA nilcheckelim pass. Sadly, it significant increases the number of allocations. Let's circle around sometime later (when we're not focused on getting basic coverage and correctness) and see whether we can make that a little cheaper on the memory front.

/cc @tzneal
@dr2chase
Copy link
Contributor

dr2chase commented Aug 5, 2015

For "allocates a lot", are we worried about allocation count, or total size of all allocations?

@josharian
Copy link
Contributor Author

It was the allocation count that caught my eye.

@rsc rsc added this to the Go1.6 milestone Aug 6, 2015
@rsc rsc modified the milestones: dev.ssa, Go1.6 Nov 4, 2015
@bradfitz bradfitz modified the milestones: dev.ssa, Go1.7 Mar 2, 2016
@rsc rsc modified the milestones: Go1.8, Go1.7 May 17, 2016
@gopherbot
Copy link

CL https://golang.org/cl/30671 mentions this issue.

@golang golang locked and limited conversation to collaborators Oct 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
5 participants
@bradfitz @josharian @rsc @dr2chase @gopherbot