Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: sys_windows_amd64.s not setting r2 return value #12018

Closed
jonforums opened this issue Aug 4, 2015 · 1 comment
Closed

runtime: sys_windows_amd64.s not setting r2 return value #12018

jonforums opened this issue Aug 4, 2015 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.6

Comments

@jonforums
Copy link

As discussed at this golang-nuts post, the runtime·asmstdcall function for windows/amd64 uses this return code

// Return result.
POPQ    CX
MOVQ    AX, libcall_r1(CX)

while corresponding code from runtime/sys_windows_386.s uses

// Return result.
MOVL    fn+0(FP), BX
MOVL    AX, libcall_r1(BX)
MOVL    DX, libcall_r2(BX)

Go asm for 386 and amd64 for darwin, linux, and freebsd in syscall/asm_*.s all return r2 from DX like the above windows/386 snippet.
@ianlancetaylor ianlancetaylor added this to the Go1.6 milestone Aug 4, 2015
@jonforums
Copy link
Author

As I've updated the golang-nuts post, I now believe this to be a non-issue (my misunderstanding) rather than a go windows/amd64 bug.

@golang golang locked and limited conversation to collaborators Aug 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.6
Development

No branches or pull requests
4 participants
@davecheney @jonforums @ianlancetaylor @gopherbot