Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: Exclude vendor from "./..." #12010

Closed
ishbir opened this issue Aug 4, 2015 · 3 comments
Closed

cmd/go: Exclude vendor from "./..." #12010

ishbir opened this issue Aug 4, 2015 · 3 comments
Labels
FrozenDueToAge

Comments

@ishbir
Copy link

ishbir commented Aug 4, 2015

All go tools/subcommands, such as build, test, vet, fmt should exclude traversing the vendor directory when "./..." is given as the argument. Right now, one has to go through 'hacks' to get intended operation.

For example, what it is right now:

go vet ./... 2>&1 | grep -v ^vendor | grep -v '^exit status 1$'
go test ./... 2>&1 | grep -E -v '^FAIL[[:space:]]+github.com/user/repo/vendor'

What it should be:

go vet ./...
go test ./...
@bradfitz
Copy link
Contributor

bradfitz commented Aug 4, 2015

All go tools/subcommands, such as build, test, vet, fmt should exclude traversing the vendor directory when "./..." is given as the argument.

I disagree.

In any case, there are already open bugs discussing this.

@bradfitz
Copy link
Contributor

bradfitz commented Aug 4, 2015

Dup of #11659

@bradfitz bradfitz closed this as completed Aug 4, 2015
@davecheney
Copy link
Contributor

I agree with the OP, vendored code should be invisible to the tools, just
as if it was in another GOPATH segment.

On Tue, Aug 4, 2015 at 3:23 PM, Brad Fitzpatrick notifications@github.com
wrote:

All go tools/subcommands, such as build, test, vet, fmt should exclude
traversing the vendor directory when "./..." is given as the argument.

I disagree.

In any case, there are already open bugs discussing this.

—
Reply to this email directly or view it on GitHub
#12010 (comment).

@mikioh mikioh changed the title Exclude vendor from "./..." cmd/go: Exclude vendor from "./..." Aug 4, 2015
@golang golang locked and limited conversation to collaborators Aug 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bradfitz @davecheney @ishbir @gopherbot