Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: reenable TestCgoCallbackGC on dragonfly #11990

Open
mikioh opened this issue Aug 3, 2015 · 6 comments
Open

runtime: reenable TestCgoCallbackGC on dragonfly #11990

mikioh opened this issue Aug 3, 2015 · 6 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. OS-Dragonfly
Milestone
Unplanned

Comments

@mikioh
Copy link
Contributor

mikioh commented Aug 3, 2015

For example,

go test -v -run=TestCgoCallbackGC
=== RUN   TestCgoCallbackGC
--- PASS: TestCgoCallbackGC (175.54s)
PASS
ok      runtime 175.548s

Not sure the reason but it perhaps harms the dragonfly buildbot.
@mikioh mikioh added this to the Unplanned milestone Aug 3, 2015
@mikioh
Copy link
Contributor Author

mikioh commented Aug 3, 2015

% uname -a
DragonFly 4.2-RELEASE DragonFly v4.2.3.5.g519f0-RELEASE /usr/obj/usr/src/sys/X86_64_GENERIC x86_64

@mikioh mikioh modified the milestones: Go1.5, Unplanned Aug 3, 2015
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/13050 mentions this issue.

mikioh pushed a commit that referenced this issue Aug 3, 2015
@cixtor
runtime: skip TestCgoCallbackGC on dragonfly
5e15e28 
Updates #11990.

Change-Id: I6c58923a1b5a3805acfb6e333e3c9e87f4edf4ba
Reviewed-on: https://go-review.googlesource.com/13050
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@mikioh mikioh modified the milestones: Go1.6, Go1.5 Aug 3, 2015
@rsc
Copy link
Contributor

rsc commented Nov 23, 2015

Work on Dragonfly is unplanned, since it is not a first-class port.

@rsc rsc modified the milestones: Unplanned, Go1.6 Nov 23, 2015
@mikioh mikioh modified the milestones: Go1.8, Unplanned May 19, 2016
@mikioh
Copy link
Contributor Author

mikioh commented May 20, 2016

Looks like DragonFly BSD 4.4.x kernels have no issues. Let's re-enable TestCgoCallbackGC in Go 1.8.

@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 29, 2016
@quentinmit quentinmit changed the title runtime: TestCgoCallbackGC takes a bit long time (175.54s) on dragonfly runtime: reenable TestCgoCallbackGC on dragonfly Sep 29, 2016
@quentinmit quentinmit self-assigned this Sep 29, 2016
@mikioh
Copy link
Contributor Author

mikioh commented Oct 1, 2016

Just tried TestCgoCallbackGC w/ tip (go version devel +09fb795) on DragonFly v4.6.0.20.ged336-RELEASE.

go test -v -run=TestCgoCallbackGC -count=10
=== RUN   TestCgoCallbackGC
--- PASS: TestCgoCallbackGC (11.94s)
=== RUN   TestCgoCallbackGC
--- PASS: TestCgoCallbackGC (13.78s)
=== RUN   TestCgoCallbackGC
--- PASS: TestCgoCallbackGC (17.62s)
=== RUN   TestCgoCallbackGC
--- PASS: TestCgoCallbackGC (9.06s)
=== RUN   TestCgoCallbackGC
--- PASS: TestCgoCallbackGC (39.77s)
=== RUN   TestCgoCallbackGC
--- PASS: TestCgoCallbackGC (4.68s)
=== RUN   TestCgoCallbackGC
--- PASS: TestCgoCallbackGC (39.87s)
=== RUN   TestCgoCallbackGC
--- PASS: TestCgoCallbackGC (32.53s)
=== RUN   TestCgoCallbackGC
--- PASS: TestCgoCallbackGC (18.07s)
=== RUN   TestCgoCallbackGC
--- PASS: TestCgoCallbackGC (22.77s)
PASS
ok      runtime 210.103s

Perhaps it might be better to mark this issue with unplanned.

@quentinmit
Copy link
Contributor

Okay, it sounds like you think 10-30s is too slow. -> Unplanned.

@quentinmit quentinmit removed their assignment Oct 14, 2016
@quentinmit quentinmit modified the milestones: Unplanned, Go1.8 Oct 14, 2016
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. OS-Dragonfly
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
4 participants
@mikioh @rsc @quentinmit @gopherbot