Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syscall: syscall.SIGABRT not defined for Plan 9 #11975

Closed
griesemer opened this issue Jul 31, 2015 · 6 comments
Closed

syscall: syscall.SIGABRT not defined for Plan 9 #11975

griesemer opened this issue Jul 31, 2015 · 6 comments
Labels
FrozenDueToAge OS-Plan9
Milestone
Go1.6

Comments

@griesemer
Copy link
Contributor

The x/tools/cmd/stress package uses it and cannot be built for Plan 9.

See e.g.: http://farmer.golang.org/temporarylogs?name=plan9-386&rev=883bc6ed0ea815293fe6309d66f967ea60630e87&st=0xc829582fc0&subName=tools&subRev=32dcbb4ccca1d39fc73d6d9707d72e31d53fa0e1
griesemer added a commit to golang/tools that referenced this issue Jul 31, 2015
@griesemer
x/tools/cmd/stress: don't build for Plan 9 (syscall.SIGABRT not defined)
5a6a7b4 
See golang/go#11975.
For golang/go#11811.

Change-Id: I56ee20cd798bf963afdf3c81c4745f07850f6dcc
Reviewed-on: https://go-review.googlesource.com/13034
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@ianlancetaylor ianlancetaylor added this to the Unplanned milestone Jul 31, 2015
@0intro 0intro self-assigned this Aug 13, 2015
@0intro
Copy link
Member

0intro commented Aug 13, 2015

I've a fix for this issue. I'll send a CL once the Go 1.6 tree will be open.

@0intro 0intro modified the milestones: Go1.6, Unplanned Aug 13, 2015
@rsc
Copy link
Contributor

rsc commented Oct 24, 2015

Do you want to send a fix?

@0intro
Copy link
Member

0intro commented Oct 24, 2015

I've implemented a special "abort" note as _SigThrow, which causes
the sighandler to print a stack trace and exit.

Does it sound good to you?

@gopherbot
Copy link

CL https://golang.org/cl/16300 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/16301 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/16306 mentions this issue.

0intro added a commit that referenced this issue Oct 26, 2015
@0intro
runtime: handle abort note on Plan 9
d093bf4 
Implement an abort note on Plan 9, as an
equivalent of the SIGABRT signal on other
operating systems.

Updates #11975.

Change-Id: I010c9b10f2fbd2471aacd1d073368d975a2f0592
Reviewed-on: https://go-review.googlesource.com/16300
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: David du Colombier <0intro@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
0intro added a commit that referenced this issue Oct 26, 2015
@0intro
syscall: define common notes on Plan 9
8993f79 
There is no signal list on Plan 9, since notes
are strings. However, some programs expect
signals to be defined in the syscall package.
Hence, we define a list of the most common notes.

Updates #11975.

Change-Id: I852e14fd98777c9595a406e04125be1cbebed0fb
Reviewed-on: https://go-review.googlesource.com/16301
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: David du Colombier <0intro@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Oct 26, 2016
@rsc rsc unassigned 0intro Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-Plan9
Projects
None yet
Milestone
Go1.6
Development

No branches or pull requests
5 participants
@rsc @ianlancetaylor @0intro @griesemer @gopherbot