Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: get fails with bad internal package errors #11960

Closed
okdave opened this issue Jul 31, 2015 · 1 comment
Closed

cmd/go: get fails with bad internal package errors #11960

okdave opened this issue Jul 31, 2015 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.5

Comments

@okdave
Copy link
Contributor

okdave commented Jul 31, 2015

Importing a path ending with ... that uses internal packages causes strange errors about internal packages not being allowed to import themselves.

$ go version
go version devel +d3ffc97 Wed Jul 29 23:50:20 2015 +0000 darwin/amd64

$  mkdir /tmp/gopath || rm -rf /tmp/gopath/src
$ GOPATH=/tmp/gopath go get google.golang.org/cloud/...
package google.golang.org/cloud/bigtable/internal/cbtrc
    imports google.golang.org/cloud/bigtable/internal/cbtrc: use of internal package not allowed
package google.golang.org/cloud/bigtable/internal/cluster_data_proto
    imports google.golang.org/cloud/bigtable/internal/cluster_data_proto: use of internal package not allowed
package google.golang.org/cloud/bigtable/internal/cluster_service_proto
    imports google.golang.org/cloud/bigtable/internal/cluster_service_proto: use of internal package not allowed
package google.golang.org/cloud/bigtable/internal/data_proto
    imports google.golang.org/cloud/bigtable/internal/data_proto: use of internal package not allowed
package google.golang.org/cloud/bigtable/internal/duration_proto
    imports google.golang.org/cloud/bigtable/internal/duration_proto: use of internal package not allowed
etc...

This doesn't fail if the ... suffix is dropped. It also succeeds if you repeat the go get a second time without destroying GOPATH first.

Might be related to #11307, except the -u flag seems to have no effect here.
Similar to #11828 in that it only fails with ... on an empty GOPATH
@okdave okdave added this to the Go1.5 milestone Jul 31, 2015
@radeksimko radeksimko mentioned this issue Jul 31, 2015
Merged
rsc added a commit to rsc/go-get-issue-11960 that referenced this issue Jul 31, 2015
@rsc
test case for golang/go#11960.
fb63800
@gopherbot
Copy link

CL https://golang.org/cl/13023 mentions this issue.

@rsc rsc closed this as completed in 226b28c Jul 31, 2015
@golang golang locked and limited conversation to collaborators Aug 5, 2016
@rsc rsc removed their assignment Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
3 participants
@rsc @okdave @gopherbot