Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestIPv4MulticastListener fails on linux without CONFIG_IP_MULTICAST #11936

Closed
jefby opened this issue Jul 30, 2015 · 8 comments
Closed
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@jefby
Copy link

jefby commented Jul 30, 2015

1. TestIPv4MulticastListener error

ok      mime/quotedprintable    2.580s
--- FAIL: TestIPv4MulticastListener (0.00s)
    listen_test.go:556: 224.0.0.254 not found in multicast rib
FAIL
FAIL    net 2.866s
@bradfitz bradfitz changed the title arm64 TestIPV4MulticastListener error net: arm64 TestIPV4MulticastListener error Jul 30, 2015
@mikioh mikioh changed the title net: arm64 TestIPV4MulticastListener error net: TestIPv4MulticastListener fails on linux/arm64 Jul 30, 2015
@mikioh mikioh added this to the Unplanned milestone Jul 30, 2015
@mikioh
Copy link
Contributor

mikioh commented Jul 30, 2015

Thanks. Can you show us the output of the following on your node under the test? (Please anonymize IDs in the output if necessary)

ip -4 route show
ip link show
ip -4 neighbor show

Thanks.

@mwhudson
Copy link
Contributor

I did some poking at this and basically came to the conclusion that it's a missing kernel feature (the same test fails on my dragonboard 401c). Does /proc/net/igmp exist?

@jefby
Copy link
Author

jefby commented Jul 30, 2015

@mikioh

[root@ ~]# ip -4 route show
192.168.3.0/24 dev enP2p1s0f2  proto kernel  scope link  src 192.168.3.1
[root@crb-1s ~]# ip link show
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
2: enP2p1s0f1: <BROADCAST,MULTICAST> mtu 1500 qdisc mq state DOWN mode DEFAULT group default qlen 1000
    link/ether d2:a3:56:a6:82:29 brd ff:ff:ff:ff:ff:ff
3: enP2p1s0f2: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP mode DEFAULT group default qlen 1000
    link/ether d6:06:87:8b:4a:f1 brd ff:ff:ff:ff:ff:ff
4: enP2p1s0f3: <BROADCAST,MULTICAST> mtu 1500 qdisc mq state DOWN mode DEFAULT group default qlen 1000
    link/ether 9e:8c:15:20:e4:85 brd ff:ff:ff:ff:ff:ff
5: enP2p1s0f4: <BROADCAST,MULTICAST> mtu 1500 qdisc mq state DOWN mode DEFAULT group default qlen 1000
    link/ether d6:ac:00:96:94:bf brd ff:ff:ff:ff:ff:ff
6: enP2p1s0f5: <BROADCAST,MULTICAST> mtu 1500 qdisc mq state DOWN mode DEFAULT group default qlen 1000
    link/ether 82:2c:5e:c7:e2:53 brd ff:ff:ff:ff:ff:ff
[root@crb-1s ~]# ip -4 neighbor show
192.168.3.97 dev enP2p1s0f2 lladdr 2e:4c:0c:00:00:00 STALE
192.168.3.58 dev enP2p1s0f2 lladdr fc:aa:14:9d:bd:90 STALE
192.168.3.47 dev enP2p1s0f2  FAILED
192.168.3.28 dev enP2p1s0f2 lladdr 3e:c6:4c:d9:e8:5f STALE
192.168.3.93 dev enP2p1s0f2  FAILED
192.168.3.71 dev enP2p1s0f2 lladdr 02:f7:ea:cd:68:2f STALE

@jefby
Copy link
Author

jefby commented Jul 30, 2015

@mwhudson there is no /proc/net/igmp in my system.Do you mean the file is very important for testcase??

@mwhudson
Copy link
Contributor

Well, I think there is some kernel option that's required for this test to work that you do not have enabled -- maybe CONFIG_IP_MULTICAST? I'm not sure. Did you build your own kernel? This test passes on Ubuntu kernels, for example.

@jefby
Copy link
Author

jefby commented Jul 30, 2015

@mwhudson Yes,the kernel is ourselves , CONFIG_IP_MULTICAST is not set in kernel config,i add this and try it again.

@bradfitz
Copy link
Contributor

Go should just skip these tests if the kernel can't do multicast.

@mikioh
Copy link
Contributor

mikioh commented Jul 30, 2015

@jefby,

Thanks. We use /proc/net/{igmp,igmp6} in network interface APIs instead of scraping rib/fib inside the kernel for convenience, and TestIPv4MulticastListener tests those APIs. Will fix test cases in go1.6.

@mikioh mikioh modified the milestones: Go1.6, Unplanned Jul 30, 2015
@mikioh mikioh changed the title net: TestIPv4MulticastListener fails on linux/arm64 net: TestIPv4MulticastListener fails on linux without CONFIG_IP_MULTICAST Jul 30, 2015
@mikioh mikioh added the Testing An issue that has been verified to require only test changes, not just a test failure. label Aug 4, 2015
@mikioh mikioh removed their assignment Sep 23, 2015
@jefby jefby closed this as completed Nov 24, 2015
@golang golang locked and limited conversation to collaborators Nov 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

5 participants