New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syscall: linux/arm64 has Lchown but kernel doesn't implement it #11918
Comments
This seems like a question for a Docker mailing list. If the kernel doesn't provide the system call and Docker is using Docker should use |
On Wed, 29 Jul 2015 17:43 Brad Fitzpatrick notifications@github.com wrote:
I think the best solution is for docker to adopt the *at style of syscalls.
|
@davecheney, is it your preference to move |
@bradfitz yes. This is probably one Aram and I missed (possibly there is no test for it in the os package). I think this can wait til 1.6, I don't want to fight Rob and Russ for it at this late stage. |
I'd support it. arm64 is experimental anyway (so low risk of breaking anything... and not like it works anyway), and Docker wants to use this. I'd just send a CL. People can |
@davecheney Yes,i'd support it. my pleasure. I have the arm64 hardware and will quickly test it in arm64. |
https://go-review.googlesource.com/12833 I'll test this tomorrow if it is not already shot down by that time. If committed I'll take care of porting this to x/syscall. |
CL https://golang.org/cl/12833 mentions this issue. |
@jefby could you please apply https://go-review.googlesource.com/#/c/12834/ and confirm that it does not pass on arm64. |
@davecheney ok,i will try now. |
CL https://golang.org/cl/12834 mentions this issue. |
@davecheney great job! Command "docker pull fedora" in arm64 runs ok, don't print the lchown error, but start docker it prints a function not implement ,i don't know whether is or not the golang syscall difference between arm64 and x86_64. docker server infomation 👍
docker client
|
Can you run the program under strace -f and paste the relevant part? On Wed, Jul 29, 2015 at 10:03 PM, jefby notifications@github.com wrote:
|
Let's keep these bugs focused. Maybe move Docker porting discussions elsewhere, or file new bugs for other system calls that don't work. I deleted the really long strace results because they made this page basically unusable and I also saw nothing useful in them either (mostly futex spam). Feel free to re-post it as a link to a gist or something hosted elsewhere if you'd like. |
@bradfitz @davecheney ,docker start container-id error ,the main information is like below ,maybe the ptrace(SYSCALL) is not implement in arm64???
|
@jefby that looks like some code tried to ptrace this child process after On Wed, 29 Jul 2015 23:50 jefby notifications@github.com wrote:
|
@davecheney Thanks very much.Maybe it's the bug docker 1.7.1-rc3 ,when i upgrade it to version1.8-dev it can work now. |
Fixes #11919 Issue #11918 suggested that os.File.Chown and os.Lchown were under tested. Change-Id: Ib41f7cb2d2fe0066d2ccb4d1bdabe1795efe80fc Reviewed-on: https://go-review.googlesource.com/12834 Reviewed-by: Russ Cox <rsc@golang.org> Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
Hello, i port the docker 1.7.1-rc3 to arm64,and it runs the command like docker pull fedora it will failed,because arm64 kernel not provides the syscall lchown, so how to insist this to run docker correctly??
in go/src/syscall directory, run like this , it will print the kernel provides the syscall:
./mksysnum_linux.pl /usr/include/asm-generic/unistd.h, there are no lchown;
and when in x86_64,it provides the lchown syscall ,and my question is how to correct it in arm64 ?
The text was updated successfully, but these errors were encountered: