Please, provide instructions to reproduce your issue. Thank you.

Alex

This is depend on behavior of escape arguments on unix-shell or cmd.exe.

Thank you @mattn. This is how it works on linux too:

# pwd
/root/src/issue 11868
# cat main.go
package main
//#cgo CFLAGS: -I${SRCDIR}/../../include
import "C"
func main() {
}
# go build
can't load package: package issue 11868: /root/src/issue 11868/main.go: malformed #cgo argument: -I/root/src/issue 11868/../../include
#

It appears we don't allow space inside of #cgo line parameters. I don't know why is that. Leaving for others to explain.

Alex

It's a bug.

I don't know if changing safeCgoName in go/build/build.go is sufficient, or whether we need to add quoting somewhere.

gcc doesn't allows "-I/path/to directory". it should be -I"/path/to directory". (at least, on windows)

Have there been any more thoughts on how this can be fixed? If someone could point me in the right direction, I'd be happy to try to fix it myself.

@jtsylve Thanks--I would start with my suggestion above: look at safeCgoName in go/build/build.go. Fix that to accept spaces. Then make sure any necessary quoting is done.

It is important that an attempted fix here does not allow spaces in other places. Changing safeCgoName sounds dangerous.

It does seem reasonable that ${SRCDIR}'s expansion should be properly handled even when that variable contains spaces.

The issue is more complicated than just changing safeCgoName, unfortunately. In order to make it work correctly with gcc we need to allow quotes. splitQuoted tends to affect this negatively. I have yet to come up with a reasonable solution.

CL https://golang.org/cl/16302 mentions this issue.

Under which cases is splitQuoted needed and when should we avoid spaces as @rsc mentioned?