-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: regexp: port RE2's CoalesceWalker to Go's regexp package #11855
Comments
CC @rsc |
Go's regexp isn't trying to be at performance parity with RE2, which is overengineered. The issue of ambiguity is mostly an internal matter. Is all this code worthwhile for the core library? RE2 is available for wrapping if you need it. |
Fair call. I had observed that Go already supports factoring out common prefixes of alternations as per https://github.com/golang/go/blob/master/src/regexp/syntax/parse.go#L394, so I figured that I would at least offer. :) |
It's good to know it's there, but I think we can wait until a need arises. Thanks. @adg, how does one decline a proposal? |
@rsc say "Thanks, but we'll decline for now." and close the issue. (like so :-)) |
google/re2@b77e1a4 added an optimisation to RE2. I'm offering to port this to Go's regexp package for the sake of feature parity.
The text was updated successfully, but these errors were encountered: