Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/mobile/app: Build error on darwin_amd64 #11827

Closed
shazow opened this issue Jul 22, 2015 · 1 comment
Closed

x/mobile/app: Build error on darwin_amd64 #11827

shazow opened this issue Jul 22, 2015 · 1 comment
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@shazow
Copy link
Contributor

shazow commented Jul 22, 2015

Recent patch that adds keyboard events to x/mobile on OSX (golang/mobile@de4ba64, cc @crawshaw) is failing to build on 10.9.5. Looks like it's because the ARepeat property is only available on OSX 10.10 and newer: https://developer.apple.com/library/mac/documentation/Cocoa/Reference/ApplicationKit/Classes/NSEvent_Class/#//apple_ref/occ/instp/NSEvent/ARepeat

$ go build .
# golang.org/x/mobile/app
../../local/go1.5/src/golang.org/x/mobile/app/darwin_amd64.m:192:15: error: property 'ARepeat' not found on object of type 'NSEvent *'

go version devel +71832ff Fri Jul 3 21:39:04 2015 +0000 darwin/amd64 on OSX 10.9.5
@crawshaw crawshaw self-assigned this Jul 22, 2015
@gopherbot
Copy link

CL https://golang.org/cl/12552 mentions this issue.

@ianlancetaylor ianlancetaylor added this to the Unreleased milestone Jul 22, 2015
@golang golang locked and limited conversation to collaborators Aug 5, 2016
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 10, 2021
@crawshaw
app: use isARepeat method instead of ARepeat prop
5d86e4a 
The property was only introduced in 10.10, and doesn't offer us
anything more than what the method gives us.

Fixes golang/go#11827.

Change-Id: I5a9f9b068b9f18acc85a68a37dae11f19df686a1
Reviewed-on: https://go-review.googlesource.com/12552
Reviewed-by: Andrey Petrov <shazow@gmail.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 11, 2021
@crawshaw
app: use isARepeat method instead of ARepeat prop
d878530 
The property was only introduced in 10.10, and doesn't offer us
anything more than what the method gives us.

Fixes golang/go#11827.

Change-Id: I5a9f9b068b9f18acc85a68a37dae11f19df686a1
Reviewed-on: https://go-review.googlesource.com/12552
Reviewed-by: Andrey Petrov <shazow@gmail.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@shazow @crawshaw @ianlancetaylor @gopherbot