Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gomote: put14 reports "unknown builder" #11711

Closed
aclements opened this issue Jul 14, 2015 · 3 comments
Closed

x/build/cmd/gomote: put14 reports "unknown builder" #11711

aclements opened this issue Jul 14, 2015 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone
Unreleased

Comments

@aclements
Copy link
Member 

$ gomote create openbsd-386-gce56
$ gomote push user-austin-openbsd-386-gce56-0
$ gomote put14 user-austin-openbsd-386-gce56-0
Error running put14: unknown builder "user-austin-openbsd-386-gce56-0"

I think namedConfig in list.go hasn't kept up with the user-x-builder-n notation, since it looks for a build config whose name is a prefix of the given buildlet name. Simply changing HasPrefix to Contains works for my case, but feels like an ugly solution.
@ianlancetaylor ianlancetaylor added this to the Unreleased milestone Jul 14, 2015
@bradfitz
Copy link
Contributor

Thanks for the report.

I forgot about the put14 command when we changed the auth. FWIW, put14 isn't very useful, since push does it for you anyway. I think we've made the decision to just nuke the old auth mode and old user-x-builder-n notation entirely (which was never finished anyway), and use the new proxy-via-coordinator style. That will simplify the gomote code. I'll use this bug for that.

@bradfitz bradfitz added the Builders x/build issues (builders, bots, dashboards) label Jul 14, 2015
@aclements
Copy link
Member Author

FWIW, put14 isn't very useful, since push does it for you anyway.

It looked like this wasn't working because it also depended on namedConfig.

@gopherbot
Copy link

CL https://golang.org/cl/12393 mentions this issue.

@golang golang locked and limited conversation to collaborators Jul 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @aclements @ianlancetaylor @gopherbot