Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/proxy: SOCKS5 errors are all *errors.errorString #11682

Closed
ger5 opened this issue Jul 12, 2015 · 2 comments
Closed

x/net/proxy: SOCKS5 errors are all *errors.errorString #11682

ger5 opened this issue Jul 12, 2015 · 2 comments
Labels
FrozenDueToAge
Milestone
Unplanned

Comments

@ger5
Copy link

ger5 commented Jul 12, 2015

The errors returned by proxy.SOCKS5() are all created with errors.New, meaning package users have to parse strings to determine what happened. At the minimum, they should satisfy net.Error so users can distinguish between timeouts and temporary errors.
@rsc rsc added this to the Unplanned milestone Jul 22, 2015
@mikioh mikioh changed the title net/proxy: SOCKS5 errors are all *errors.errorString x/net/proxy: SOCKS5 errors are all *errors.errorString Jul 23, 2015
@mikioh mikioh mentioned this issue Mar 24, 2017
Closed
@gopherbot
Copy link

CL https://golang.org/cl/38278 mentions this issue.

@gopherbot
Copy link

Change https://golang.org/cl/41031 mentions this issue: net/http: replace SOCKS client implementation

gopherbot pushed a commit that referenced this issue Apr 6, 2018
@cixtor @bradfitz
net/http: replace SOCKS client implementation
4acb305 
This change replaces the vendored socks client implementation with the
bundle of golang.org/x/net/internal/socks package which contains fixes
for 19354 and 11682.

golang.org/x/net/internal/socks becomes socks_bundle.go.

At git rev 61147c4. (golang.org/cl/38278)

Updates #11682.
Updates #18508.
Updates #19354.
Fixes #19688.
Updates #21333.

Change-Id: I8cf6c3f5eb87c24685a7592be015729f84fbed77
Reviewed-on: https://go-review.googlesource.com/41031
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Apr 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
3 participants
@rsc @gopherbot @ger5