Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: vendored import lookup fails when cwd contains is symlink #11679

Closed
wathiede opened this issue Jul 12, 2015 · 2 comments
Closed

cmd/go: vendored import lookup fails when cwd contains is symlink #11679

wathiede opened this issue Jul 12, 2015 · 2 comments

Comments

@wathiede
Copy link
Member

$ go version
go version devel +2ae7737 Sat Jul 11 14:36:33 2015 +0000 freebsd/amd64

There are tests failing at HEAD on my machine with a clean checkout

$ go test -run TestVendor
--- FAIL: TestVendorRun (0.01s)
        go_test.go:237: running testgo [run hello.go]
        go_test.go:256: standard error:
        go_test.go:257: invalid vendoredImportPath: dir="/usr/home/wathiede/go/src/cmd/go/testdata/src/vend/hello" root="/home/wathiede/go/src/cmd/go/testdata" separator="/"

        go_test.go:266: go [run hello.go] failed unexpectedly: exit status 1
--- FAIL: TestVendorGOPATH (0.01s)
        go_test.go:237: running testgo [run hello.go]
        go_test.go:256: standard error:
        go_test.go:257: invalid vendoredImportPath: dir="/usr/home/wathiede/go/src/cmd/go/testdata/src/vend/hello" root="/home/wathiede/go/src/cmd/go/testdata" separator="/"

        go_test.go:266: go [run hello.go] failed unexpectedly: exit status 1
FAIL
exit status 1
FAIL    cmd/go  2.972s

I think these test failures are somehow related to the fact my system has HOME set to /home/$USER, but /home is a symlink to /usr/home

$ echo $HOME
/home/wathiede

$ readlink -f $HOME
/usr/home/wathiede

$ ls -l /home 
lrwxr-xr-x  1 root  wheel  10 Apr 23  2011 /home -> /usr/home/
@ianlancetaylor ianlancetaylor added this to the Go1.5Maybe milestone Jul 12, 2015
@ebfe
Copy link
Contributor

ebfe commented Jul 12, 2015

See also #11305

@wathiede
Copy link
Member Author

This does seem like a dupe of #11305, I'll close it.

@golang golang locked and limited conversation to collaborators Jul 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants