Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image/draw: Draw is slow on Paletted images #11550

Closed
nicks opened this issue Jul 3, 2015 · 4 comments
Closed

image/draw: Draw is slow on Paletted images #11550

nicks opened this issue Jul 3, 2015 · 4 comments
Labels
FrozenDueToAge
Milestone
Go1.5

Comments

@nicks
Copy link

nicks commented Jul 3, 2015

I've been investigating an issue where drawing Paletted images seems much slower than other types of image conversion.

AFAIK, it's drawing the image twice?

go/src/image/draw/draw.go

Line 178 in f9ed2f7

drawPaletted(dst0, r, src, sp, false)

It executes the "fast" drawPaletted image, then falls into the default case, and executes the "slow" drawing path? I think there's supposed to be a return there?
@bradfitz
Copy link
Contributor

bradfitz commented Jul 3, 2015

@nigeltao?

@nigeltao
Copy link
Contributor

nigeltao commented Jul 3, 2015

You're absolutely right. I'll send out a fix.

@gopherbot
Copy link

CL https://golang.org/cl/11858 mentions this issue.

@nicks
Copy link
Author

nicks commented Jul 3, 2015

thanks Nigel! that was quick 💨

@mikioh mikioh changed the title image/draw:Draw is slow on Paletted images image/draw: Draw is slow on Paletted images Jul 3, 2015
@mikioh mikioh added this to the Go1.5 milestone Jul 3, 2015
@golang golang locked and limited conversation to collaborators Jul 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
5 participants
@bradfitz @mikioh @nicks @nigeltao @gopherbot