Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/mobile/cmd/gomobile: fails to compile (types.TypeString) #11509

Closed
wjarek-zz opened this issue Jul 2, 2015 · 1 comment
Closed

x/mobile/cmd/gomobile: fails to compile (types.TypeString) #11509

wjarek-zz opened this issue Jul 2, 2015 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.5

Comments

@wjarek-zz
Copy link

I was trying to build gomobile from the tip and go get golang.org/x/mobile/cmd/gomobile fails to compile with this error 'src/golang.org/x/mobile/bind/gengo.go:376: cannot use pkg (type *types.Package) as type types.Type in argument to types.TypeString:
*types.Package does not implement types.Type (missing Underlying method)

Looking at:

golang/tools@997b354#diff-a3b3e01a6877f510d37ff84ed5356341L33

I see that TypeString no longer takes a *Package as expected in gengo.go.
@rakyll rakyll added this to the Go1.5 milestone Jul 2, 2015
@rakyll rakyll changed the title golang.org/x/mobile/cmd/gomobile fails to compile (types.TypeString) x/mobile/cmd/gomobile: fails to compile (types.TypeString) Jul 2, 2015
@nwswe
Copy link

nwswe commented Jul 2, 2015

+1 im hitting this issue as well.

@golang golang locked and limited conversation to collaborators Jul 1, 2016
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 10, 2021
@adonovan
bind: fix build broken by API change to golang.org/x/tools/go/types
9d2a7ba 
Fixes golang/go#11509.

Change-Id: Ia54febfa3ef9b589befb09b8f5d79cb6d7f6c4da
Reviewed-on: https://go-review.googlesource.com/11841
Reviewed-by: Robert Griesemer <gri@golang.org>
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 11, 2021
@adonovan
bind: fix build broken by API change to golang.org/x/tools/go/types
454c458 
Fixes golang/go#11509.

Change-Id: Ia54febfa3ef9b589befb09b8f5d79cb6d7f6c4da
Reviewed-on: https://go-review.googlesource.com/11841
Reviewed-by: Robert Griesemer <gri@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
4 participants
@rakyll @wjarek-zz @gopherbot @nwswe