Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/tls: Minor issues with doc and error msgs #1146

Closed
gopherbot opened this issue Sep 27, 2010 · 3 comments
Closed

crypto/tls: Minor issues with doc and error msgs #1146

gopherbot opened this issue Sep 27, 2010 · 3 comments
Labels
FrozenDueToAge

Comments

@gopherbot
Copy link

by jan.newmarch:

Which revision are you using?  (hg identify)
5a552276eca3 tip

Struggling a bit with tls due to these doco/error msg:

Doc for tls.LoadX509KeyPair should say the certfile and keyfile have to be PEM encoded.
Other encodings won't work.

c.sendAlert(alertBadCertificate)) occurs 8 times in handshake_client.go and
handshake_server.go. A detail field of which error caused the BadCert would help
debugging: I have a cert on a server which is accepted by "openssl s_client -tls1 
-connect localhost:1200" but not by tls.Dial, and tracking this down means reading
code rather than error messages.
@adg
Copy link
Contributor

adg commented Sep 28, 2010

Comment 1:

Labels changed: added priority-low, removed priority-medium.

Owner changed to a...@golang.org.

Status changed to Accepted.

@agl
Copy link
Contributor

agl commented Oct 8, 2010

Comment 2:

http://golang.org/cl/2380042/

Labels changed: added packagebug.

Status changed to Started.

@agl
Copy link
Contributor

agl commented Oct 11, 2010

Comment 3:

This issue was closed by revision f6e2eab.

Status changed to Fixed.

@mikioh mikioh changed the title Minor issues with TLS doc and error msgs crypto/tls: Minor issues with doc and error msgs Jan 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
FiloSottile pushed a commit to FiloSottile/go that referenced this issue Oct 12, 2018
@agl
crypto/tls: better error messages for certificate issues.
dd9f217 
        Fixes golang#1146.

R=rsc, agl1
CC=golang-dev
https://golang.org/cl/2380042
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@agl @adg @gopherbot