Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: bad stack in reported import failure #11456

Closed
rsc opened this issue Jun 29, 2015 · 2 comments
Closed

cmd/go: bad stack in reported import failure #11456

rsc opened this issue Jun 29, 2015 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.5

Comments

@rsc
Copy link
Contributor

rsc commented Jun 29, 2015

I'm seeing a lot of reports about the go command reporting a problem, in which the import stack is completely bogus. For example, #11307.

In addition to fixing the reported problems, we should figure out why the import stacks are terrible and fix them.
@rsc rsc added this to the Go1.5 milestone Jun 29, 2015
@rsc rsc mentioned this issue Jun 29, 2015
Closed
@jscrockett01
Copy link

Relevant comment from #11307:

Regarding the inaccurate import stacks, there is a missing stk.pop() in func download() of src/cmd/go/get.go, between lines 233-234 (go1.5beta1) corresponding to the stk.push() at line 192. Also, the stk.push/pop pair at lines 225-227 are extraneous.

@rsc
Copy link
Contributor Author

rsc commented Jul 14, 2015

I fixed the problem with the stack in #11307 as part of the fix for that bug.
In the absence of another example, closing this.

@rsc rsc closed this as completed Jul 14, 2015
@golang golang locked and limited conversation to collaborators Jul 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
3 participants
@rsc @gopherbot @jscrockett01