Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: android subrepo builds need to sync data files #11452

Closed
mikioh opened this issue Jun 29, 2015 · 6 comments
Closed

x/build: android subrepo builds need to sync data files #11452

mikioh opened this issue Jun 29, 2015 · 6 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge OS-Android
Milestone
Unreleased

Comments

@mikioh
Copy link
Contributor

mikioh commented Jun 29, 2015

See http://build.golang.org/log/ec8be097b936c5cf78f7d984ae62d39451ba6dff

go_android_exec: adb shell mkdir -p /data/local/tmp/charset.test-1846
go_android_exec: adb push /tmp/go-build720098852/golang.org/x/net/html/charset/_test/charset.test /data/local/tmp/charset.test-1846/charset.test-1846-tmp
1465 KB/s (3495200 bytes in 2.329s)
go_android_exec: adb shell cp '/data/local/tmp/charset.test-1846/charset.test-1846-tmp' '/data/local/tmp/charset.test-1846/charset.test-1846'
go_android_exec: adb shell rm '/data/local/tmp/charset.test-1846/charset.test-1846-tmp'
go_android_exec: adb shell export TMPDIR="/data/local/tmp/charset.test-1846"; export GOROOT="/data/local/tmp/goroot"; export GOPATH="/data/local/tmp/gopath"; cd "/data/local/tmp/gopath/src/golang.org/x/net/html/charset"; '/data/local/tmp/charset.test-1846/charset.test-1846' -test.short=true; echo -n exitcode=$?
/system/bin/sh: cd: /data/local/tmp/gopath/src/golang.org/x/net/html/charset: No such file or directory
@mikioh mikioh added this to the Go1.5Maybe milestone Jun 29, 2015
@rsc
Copy link
Contributor

rsc commented Jun 29, 2015

@crawshaw but pretty sure this is working as intended.

@rsc rsc modified the milestones: Unreleased, Go1.5Maybe Jun 29, 2015
@crawshaw
Copy link
Member

go_android_exec is working as intended. But this could work, with some android-specific handling is needed in the sub-repository builder. In particular, the logic from go/src/androidtest.bash needs to be replicated.

@crawshaw crawshaw changed the title misc/android: go_android_exec fails to capture sub directories x/build: android subrepo builds need to sync data files Jun 29, 2015
@crawshaw crawshaw modified the milestones: Go1.6, Unreleased Jun 29, 2015
@rsc rsc modified the milestones: Unreleased, Go1.6 Dec 5, 2015
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Mar 21, 2017
@gopherbot
Copy link

Change https://golang.org/cl/165797 mentions this issue: misc/android: enable many more tests on GOOS=android

@bradfitz
Copy link
Contributor

bradfitz commented Mar 8, 2019

@eliasnaur, I think this is all done? Leaving for you to confirm and link CLs and close.

@eliasnaur
Copy link
Contributor

Fixed by the CL mentioned above, 165797.

@eliasnaur
Copy link
Contributor

Could use your +2 :)

@golang golang locked and limited conversation to collaborators Mar 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge OS-Android
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
6 participants
@bradfitz @mikioh @rsc @crawshaw @eliasnaur @gopherbot