Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: merge gcResetGState and gcResetMarkState #11427

Closed
aclements opened this issue Jun 26, 2015 · 2 comments
Closed

runtime: merge gcResetGState and gcResetMarkState #11427

aclements opened this issue Jun 26, 2015 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.6Early

Comments

@aclements
Copy link
Member

https://go-review.googlesource.com/11561 introduced gcResetMarkState. This is needed in the same places gcResetGState is needed, but merging them requires shuffling some code around, so it was avoided for the freeze. We should merge these and, more generally, think harder about global state management in the GC, since there are an awful lot of "reset X state" functions.

@RLH
@aclements aclements self-assigned this Jun 26, 2015
@aclements aclements added this to the Go1.6Early milestone Jun 26, 2015
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/11561 mentions this issue.

aclements added a commit that referenced this issue Jun 29, 2015
@aclements
runtime: reset mark state before checkmark and gctrace=2 mark
1b91748 
Currently we fail to reset the live heap accounting state before the
checkmark mark and before the gctrace=2 extra mark. As a result, if
either are enabled, at the end of GC it thinks there are 0 bytes of
live heap, which causes the GC controller to initiate a new GC
immediately, regardless of the true heap size.

Fix this by factoring this state reset into a function and calling it
before all three possible marks.

This function should be merged with gcResetGState, but doing so
requires some additional cleanup, so it will wait for after the
freeze. Filed #11427 for this cleanup.

Fixes #10492.

Change-Id: Ibe46348916fc8368fac6f086e142815c970a6f4d
Reviewed-on: https://go-review.googlesource.com/11561
Reviewed-by: Russ Cox <rsc@golang.org>
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/16041 mentions this issue.

@golang golang locked and limited conversation to collaborators Oct 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.6Early
Development

No branches or pull requests
2 participants
@aclements @gopherbot