Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archive/tar: TestHeaderRoundTrip fails on windows, nacl, plan9 #11426

Closed
aclements opened this issue Jun 26, 2015 · 4 comments
Closed

archive/tar: TestHeaderRoundTrip fails on windows, nacl, plan9 #11426

aclements opened this issue Jun 26, 2015 · 4 comments
Labels
FrozenDueToAge OS-Plan9 OS-Windows Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.5

Comments

@aclements
Copy link
Member

Commit f271f92 broke archive/tar TestHeaderRoundTrip on Windows.

--- FAIL: TestHeaderRoundTrip (0.00s)
    tar_test.go:300: i=9: Linkname: got , want file.txt
    tar_test.go:303: &tar.Header{Name:"hard.txt", Mode:33188, Uid:0, Gid:0, Size:0, ModTime:time.Time{sec:63496197716, nsec:0, loc:(*time.Location)(0x63bfe0)}, Typeflag:0x31, Linkname:"file.txt", Uname:"", Gname:"", Devmajor:0, Devminor:0, AccessTime:time.Time{sec:0, nsec:0, loc:(*time.Location)(nil)}, ChangeTime:time.Time{sec:0, nsec:0, loc:(*time.Location)(nil)}, Xattrs:map[string]string(nil)} &tar.Header{Name:"hard.txt", Mode:33188, Uid:0, Gid:0, Size:0, ModTime:time.Time{sec:63496197716, nsec:0, loc:(*time.Location)(0x63bfe0)}, Typeflag:0x31, Linkname:"file.txt", Uname:"", Gname:"", Devmajor:0, Devminor:0, AccessTime:time.Time{sec:0, nsec:0, loc:(*time.Location)(nil)}, ChangeTime:time.Time{sec:0, nsec:0, loc:(*time.Location)(nil)}, Xattrs:map[string]string(nil)}
    tar_test.go:304: i=9: Typeflag: got '0', want '1'
    tar_test.go:288: i=10: Uid: got 0, want 1000
    tar_test.go:291: i=10: Gid: got 0, want 1000
    tar_test.go:294: i=10: Uname: got "", want "slartibartfast"
    tar_test.go:297: i=10: Gname: got "", want "users"
FAIL
FAIL    archive/tar 0.085s

From http://build.golang.org/log/44c73d1d106d1d1affeeab2bca9b49d803f9bdb3

@vbatts
@aclements aclements added this to the Go1.5 milestone Jun 26, 2015
@bradfitz
Copy link
Contributor

Disabling the test on Windows for now in https://golang.org/cl/11590

But we need to address this better for 1.5.

@bradfitz bradfitz changed the title archive/tar: fails on Windows archive/tar: fails on Windows and Plan9 Jun 26, 2015
@bradfitz
Copy link
Contributor

Also plan9.
/cc @alexbrainman @0intro

bradfitz added a commit that referenced this issue Jun 26, 2015
@bradfitz
archive/tar: disable new failing test on windows and plan9
48025d2 
Update #11426

Change-Id: If406d2efcc81965825a63c76f5448d544ba2a740
Reviewed-on: https://go-review.googlesource.com/11590
Reviewed-by: Austin Clements <austin@google.com>
@bradfitz
Copy link
Contributor

Also nacl.

@bradfitz bradfitz changed the title archive/tar: fails on Windows and Plan9 archive/tar: TestHeaderRoundTrip fails on windows, nacl, plan9 Jun 26, 2015
bradfitz added a commit that referenced this issue Jun 26, 2015
@bradfitz
archive/tar: also skip header roundtrip test on nacl
2b3b7dc 
Update #11426

Change-Id: I7abc4ed2241a7a3af6d57c934786f36de4f97b77
Reviewed-on: https://go-review.googlesource.com/11592
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/11662 mentions this issue.

@bradfitz bradfitz added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jun 30, 2015
@golang golang locked and limited conversation to collaborators Jun 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-Plan9 OS-Windows Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
3 participants
@bradfitz @aclements @gopherbot