Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/image/{tiff,bmp}: EOF instead of UnexpectedEOF #11391

Closed
dvyukov opened this issue Jun 24, 2015 · 1 comment
Closed

x/image/{tiff,bmp}: EOF instead of UnexpectedEOF #11391

dvyukov opened this issue Jun 24, 2015 · 1 comment
Labels
FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@dvyukov
Copy link
Member

dvyukov commented Jun 24, 2015

The following program prints EOF, which looks weird (whole image decoded?). Jpeg and png print UnexpectedEOF in this case. Tiff should also return UnexpectedEOF. The same for bmp package.

package main

import (
    "bytes"
    "fmt"
    "golang.org/x/image/tiff"
)

func main() {
    _, err := tiff.Decode(bytes.NewReader([]byte{}))
    fmt.Printf("err: %v\n", err)
}

on commit eb11b45157c1b71f30b3cec66306f1cd779a689e
go version devel +3cab476 Sun Jun 21 03:11:01 2015 +0000 linux/amd64
@ianlancetaylor ianlancetaylor added this to the Unreleased milestone Jul 11, 2015
@bcmills bcmills added help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 19, 2019
@bcmills bcmills mentioned this issue Aug 19, 2019
Open
oneslash pushed a commit to oneslash/image that referenced this issue Nov 5, 2019
tiff/lzw: should return io.UnexpectedEOF on empty data
50c5072 
bmp: should return io.UnexpectedEOF on empty data

fixing: golang/go#11391
@oneslash oneslash mentioned this issue Nov 5, 2019
Closed
oneslash added a commit to oneslash/image that referenced this issue Nov 5, 2019
@oneslash
tiff/lzw: should return io.UnexpectedEOF on empty data
ee7b450 
bmp: should return io.UnexpectedEOF on empty data

fixing: golang/go#11391
@gopherbot
Copy link

Change https://golang.org/cl/205458 mentions this issue: tiff, bmp: return io.UnexpectedEOF on empty data

@golang golang locked and limited conversation to collaborators Dec 5, 2020
GalaxyForcew added a commit to GalaxyForcew/A1bisshy that referenced this issue Jun 6, 2022
@GalaxyForcew
tiff, bmp: return io.UnexpectedEOF on empty data
53fd095 
Check for an EOF when decoding the tiff and bmp headers,
so that decoding empty data does not return an EOF.

Fixes golang/go#11391

Change-Id: I73394b9dcc0d2e4e2a7bc56addb3f690791820ba
GitHub-Last-Rev: 924636fca185e34399b558c92c1d4b80f43eadfc
GitHub-Pull-Request: golang/image#3
Reviewed-on: https://go-review.googlesource.com/c/image/+/205458
Run-TryBot: Akhil Indurti <aindurti@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Akhil Indurti <aindurti@gmail.com>
Reviewed-by: Nigel Tao <nigeltao@golang.org>
yi-ge3 added a commit to yi-ge3/wislie that referenced this issue Jun 6, 2022
@yi-ge3
tiff, bmp: return io.UnexpectedEOF on empty data
7d73a54 
Check for an EOF when decoding the tiff and bmp headers,
so that decoding empty data does not return an EOF.

Fixes golang/go#11391

Change-Id: I73394b9dcc0d2e4e2a7bc56addb3f690791820ba
GitHub-Last-Rev: 924636fca185e34399b558c92c1d4b80f43eadfc
GitHub-Pull-Request: golang/image#3
Reviewed-on: https://go-review.googlesource.com/c/image/+/205458
Run-TryBot: Akhil Indurti <aindurti@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Akhil Indurti <aindurti@gmail.com>
Reviewed-by: Nigel Tao <nigeltao@golang.org>
snapbakkhfbav added a commit to snapbakkhfbav/SayedBaladohr that referenced this issue Oct 6, 2022
@snapbakkhfbav
tiff, bmp: return io.UnexpectedEOF on empty data
98e6c24 
Check for an EOF when decoding the tiff and bmp headers,
so that decoding empty data does not return an EOF.

Fixes golang/go#11391

Change-Id: I73394b9dcc0d2e4e2a7bc56addb3f690791820ba
GitHub-Last-Rev: 924636fca185e34399b558c92c1d4b80f43eadfc
GitHub-Pull-Request: golang/image#3
Reviewed-on: https://go-review.googlesource.com/c/image/+/205458
Run-TryBot: Akhil Indurti <aindurti@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Akhil Indurti <aindurti@gmail.com>
Reviewed-by: Nigel Tao <nigeltao@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

tiff, bmp: return io.UnexpectedEOF on empty data oneslash/image
5 participants
@dvyukov @ianlancetaylor @bcmills @nigeltao @gopherbot