Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/types: misses '-' in error message #11367

Closed
dvyukov opened this issue Jun 23, 2015 · 0 comments
Closed

x/tools/go/types: misses '-' in error message #11367

dvyukov opened this issue Jun 23, 2015 · 0 comments
Labels
FrozenDueToAge

Comments

@dvyukov
Copy link
Member

dvyukov commented Jun 23, 2015

On the following program:

package a
var x = -byte(1)

gotype says:

tmp.go:2:10: byte(1) (constant -1 of type byte) overflows byte

It should say -byte(1). byte(1) does not overflow byte.

on commit e9a746d
griesemer added a commit that referenced this issue Jun 23, 2015
@griesemer
go/types: better error message for certain unary/binary expression er…
4ba1f25 
…rors

Port of https://go-review.googlesource.com/11363.

Fixes #11367.

Change-Id: Ie0a82bcfab782c514d1947e7a6b190e286afd159
Reviewed-on: https://go-review.googlesource.com/11367
Reviewed-by: Alan Donovan <adonovan@google.com>
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dvyukov @griesemer @gopherbot