Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/types: converts complex constant to string #11357

Closed
dvyukov opened this issue Jun 23, 2015 · 1 comment
Closed

x/tools/go/types: converts complex constant to string #11357

dvyukov opened this issue Jun 23, 2015 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.5Maybe

Comments

@dvyukov
Copy link
Member

dvyukov commented Jun 23, 2015

gotype successfully compiles the following program:

package a
var s = string(0i)

It must not. 0i is a complex constant.
on commit e9a746d
@griesemer griesemer added this to the Go1.5Maybe milestone Jun 23, 2015
@griesemer griesemer mentioned this issue Jun 23, 2015
Closed
@dvyukov
Copy link
Member Author

dvyukov commented Jun 23, 2015

When fixed please also add the test from #11353:

package n
func n(){_=string(0.)}

griesemer added a commit that referenced this issue Jun 23, 2015
@griesemer
go/types: in string(x) conversions, x must be of integer type
eb30fda 
Port of https://go-review.googlesource.com/11365

Fixes #11357.

Change-Id: Icd20fa038696a8853d1d14477e1c1132938b3e2e
Reviewed-on: https://go-review.googlesource.com/11368
Reviewed-by: Alan Donovan <adonovan@google.com>
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5Maybe
Development

No branches or pull requests
3 participants
@dvyukov @griesemer @gopherbot