Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/mobile/cmd/gomobile: build doesn't honor -target #11337

Closed
rakyll opened this issue Jun 22, 2015 · 2 comments
Closed

x/mobile/cmd/gomobile: build doesn't honor -target #11337

rakyll opened this issue Jun 22, 2015 · 2 comments
Milestone

Comments

@rakyll
Copy link
Contributor

rakyll commented Jun 22, 2015

$ gomobile build -target=misc .

builds an apk for android rather than exiting with unknown -target, misc. error.

cc/ @crawshaw @hyangah

@rakyll rakyll added this to the Go1.5 milestone Jun 22, 2015
@rakyll rakyll changed the title x/mobile/cmd/gomobile: build don't honor -target x/mobile/cmd/gomobile: build doesn't honor -target Jun 22, 2015
@rakyll rakyll self-assigned this Jun 24, 2015
@gopherbot
Copy link

CL https://golang.org/cl/11480 mentions this issue.

@crawshaw
Copy link
Member

As the explanation was not added to the CL description, it is:

addBuildFlags is called multiple times at initialization, so the String method returns a different pointer for the different commands. That means the pointer is from the wrong flag set for all but the last registered command, which is cmdBind.

@golang golang locked and limited conversation to collaborators Jun 25, 2016
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 10, 2021
Fixes golang/go#11337.

Change-Id: I324f0c4482476b6f2b084828625fd53b8f802a23
Reviewed-on: https://go-review.googlesource.com/11480
Reviewed-by: David Crawshaw <crawshaw@golang.org>
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 11, 2021
Fixes golang/go#11337.

Change-Id: I324f0c4482476b6f2b084828625fd53b8f802a23
Reviewed-on: https://go-review.googlesource.com/11480
Reviewed-by: David Crawshaw <crawshaw@golang.org>
@rsc rsc unassigned rakyll Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants