New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: vendoredImportPath doesn't follow symbolic link correctly #11305
Comments
The Go tool doesn't observe symbolic links, generally. I thought we had an open issue about this but I can't find it. |
I'm not sure which distro uses this sort of layout by default. At least it happens on my FreeBSD image which is configured with default parameters of FreeBSD installer (I guess so, maybe I chose ZFS instead of UFS) as follows:
I have no idea how much people would be annoyed by this limitation, maybe a few? |
Yeah I've observed this symlink on FreeBSD too. The question is whether it is just a test failure or indicative of a limitation of the Go tool? It shouldn't be a problem to have your GOPATH inside a symlinked directory. Or, rather, if it wasn't a problem in Go 1.4 it shouldn't become a problem now. |
FWIW, if you are using ZFS, only thing you have to do is just;
|
At least one. I don't think it is new, I ran into this before.
A less intrusive fix is to change your home directory to the path without symlink in /etc/passwd. |
It's fairly common for /home to be symlinked. Is the vendor import behaviour itself broken or is it just the test ? If it's just the test, then I imagine this is no biggie. If vendoring itself won't work in a symlinked path, then IMO that should be fixed. |
See https://groups.google.com/d/msg/golang-dev/74zjMON9glU/4lWCRDCRZg0J. Vanilla Go 1.4 source tree doesn't have this issue. As @adg said above, someone will disable TestVendorRun before the Go 1.5 cutoff when there's no easy fix. |
CL https://golang.org/cl/12194 mentions this issue. |
Tip fails build on some Unix variants.
The text was updated successfully, but these errors were encountered: